feat: add nvidia-fs kernel module#1579
Merged
Merged
Conversation
Add the nvidia-fs (gds-nvidia-fs) kernel module Fixes: siderolabs/extensions#850 Signed-off-by: Noel Georgi <git@frezbo.dev>
There was a problem hiding this comment.
Pull request overview
This PR adds the NVIDIA GPUDirect Storage kernel module (nvidia-fs.ko) to the pkgs build outputs so it can be shipped alongside the NVIDIA kernel modules (both open and proprietary variants), aligning with the request in siderolabs/extensions#850 for DMA-BUF GPUDirect RDMA enablement.
Changes:
- Introduces
gds-nvidia-fsas a new pinned, checksummed source inPkgfile. - Builds and installs the
nvidia-fskernel module in bothnvidia-open-gpu-kernel-modules(lts/production) andnonfree/kmod-nvidia(lts/production). - Updates generated tooling/config files (Makefile adjustments and adds generated
lefthook.yml).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Pkgfile | Adds version + checksums for NVIDIA/gds-nvidia-fs to be consumed by package templates. |
| nvidia-open-gpu-kernel-modules/production/pkg.yaml | Downloads, configures, builds, and installs nvidia-fs.ko alongside existing NVIDIA open modules. |
| nvidia-open-gpu-kernel-modules/lts/pkg.yaml | Same as production variant for the LTS stream. |
| nonfree/kmod-nvidia/production/pkg.yaml | Downloads, configures, builds, and installs nvidia-fs.ko for the proprietary driver package. |
| nonfree/kmod-nvidia/lts/pkg.yaml | Same as production nonfree variant for the LTS stream. |
| Makefile | Regenerates Kres output and adjusts common build args and conformance invocation. |
| lefthook.yml | Adds generated lefthook configuration to run make conformance on commit-msg. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smira
approved these changes
Jun 8, 2026
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the nvidia-fs (gds-nvidia-fs) kernel module
Fixes: siderolabs/extensions#850