feat(cli): add App.dd_resolution.tsv to supplement file handling#3764
Merged
Conversation
Per-slot DD resolution outcome diagnostic produced by gen_snapshot's `--print_dd_resolution_to=` flag in cascade-limiter builds. TSV format: slot, outcome (resolved / sentinel / null), rewritten flag, function name. Inert if absent (older Flutter pins won't produce it) since copySupplementFilesToSnapshotDirs uses maybeCopy.
eseidel
approved these changes
May 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiny follow-up to #3671. Adds
App.dd_resolution.tsvto the known supplement-file list inApple.copySupplementFilesToSnapshotDirsso the per-slot DD table resolution diagnostic (TSV) gets carried alongside the existingApp.dd.link/App.dd_callers.linkfiles.Companion changes
The TSV is produced by gen_snapshot's new
--print_dd_resolution_to=flag in cascade-limiter (shorebirdtech/dart-sdk#785), invoked by the 2-pass DD release build in shorebirdtech/flutter#119. It's a diagnostic dump used to figure out which specific slots got dropped (sentinel-filled) during DD resolution — useful for investigating patch link-percentage regressions where the aggregate count alone (8 sentinel-filled) doesn't tell you which 8 slots.Backwards compatibility
copySupplementFilesToSnapshotDirsusesmaybeCopywhich silently skips missing files. Older Flutter/engine pins that don't produceApp.dd_resolution.tsvare unaffected.Test plan
maybeCopyinvocation).App.dd_resolution.tsvin the supplement upload, and the file lands in the patch debug zip.