chore(shorebird_cli): drop dead progress stub from account command tests#3759
Merged
Conversation
The `progress` field, `MockProgress` instantiation, and `logger.progress(any())` stub were introduced in #3742 (orgs) and #3743 (apps) but never executed, because `codePushClientWrapper` is mocked at the wrapper boundary, so the progress code inside the wrapper never runs. Caught by bdero's review bot on #3743 and waived there as a follow-up. This change closes that follow-up.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nickshorebird
changed the title
easymac
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
progressfield,MockProgressinstantiation, andlogger.progress(any())stub were introduced in feat(shorebird_cli): addaccountcommand (whoami + orgs) #3742 (orgs) and feat(shorebird_cli): add account apps subcommand #3743 (apps), but never executed becausecodePushClientWrapperis mocked at the wrapper boundary, so the progress code inside the wrapper never runs.Testing
dart test test/src/commands/account/apps_command_test.dart test/src/commands/account/orgs_command_test.dart→ 20/20 passdart analyze --fatal-warnings lib test→ no new findings in the changed filesapps_command.dartandorgs_command.dartstays at 33/33 lines w/ updated tests