allowComparingOnlyComparableTypes: add support for BcMath\Number

[whataboutpereira]

Allow BcMath\Number to be compared with integers and itself.

[janedbal]

We need to be very careful about the allow/deny decisions here.

Allow BcMath\Number to be compared with integers and itself.

What makes you decide this way? Why not allow comparing to itself only? And if int is allowed, why not float?

[whataboutpereira]

We need to be very careful about the allow/deny decisions here.

Allow BcMath\Number to be compared with integers and itself.

What makes you decide this way? Why not allow comparing to itself only? And if int is allowed, why not float?

new BcMath\Number('1.35') > 1.35;

BcMath\Number doesn't work with floats and gives a deprecation notice (it does work with numeric strings though).

Same as is mentioned here #320

Deprecated: Implicit conversion from float 1.35 to int loses precision

[whataboutpereira]

Let me know if you want allowNumericString for this as well:

5a872de

[janedbal]

Let me know if you want allowNumericString for this as well:

It adds complexity and some ambiguity where exactly those numeric strings would get allowed.

So not yet. Thx

[whataboutpereira]

Cheers!