fix: add libfido2-1 and libsecret-1-0 to runtime deps#150
Open
smaier wants to merge 3 commits intoshenxn:masterfrom
Open
fix: add libfido2-1 and libsecret-1-0 to runtime deps#150smaier wants to merge 3 commits intoshenxn:masterfrom
smaier wants to merge 3 commits intoshenxn:masterfrom
Conversation
Since Proton Bridge 3.22, libfido2-1 is a required runtime dependency that was missing from the Docker image, causing container crashes on startup with a missing library error. libsecret-1-0 and ca-certificates were already present; only libfido2-1 is added here. Refs shenxn#135, shenxn#141, shenxn#147
Proton Bridge 3.22+ links against libfido2 via CGo. The build stage needs libfido2-dev (headers + pkg-config) in addition to the runtime libfido2-1 already added.
libfido2 requires libcbor at link time via CGo; libcbor-dev was missing from the build stage, causing ld to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since Proton Bridge 3.22,
libfido2-1is a required runtime dependency that is no longer bundled with the upstream binary. Containers based on this image crash at startup with a missing shared library error (libfido2.so.1).Fix
Add
libfido2-1to theapt-get installline in the runtime stage of bothbuild/Dockerfileanddeb/Dockerfile.libsecret-1-0andca-certificateswere already present.--no-install-recommendsandrm -rf /var/lib/apt/lists/*are preserved.References
Refs #135, #141, #147
Tested
Built and pushed a patched image for
linux/amd64under my Docker Hub namespace (smaier/protonmail-bridge) for verification.