Fix long-term bridge stability and stale GPG socket cleanup#134
Open
bostrot wants to merge 7 commits intoshenxn:masterfrom
Open
Fix long-term bridge stability and stale GPG socket cleanup#134bostrot wants to merge 7 commits intoshenxn:masterfrom
bostrot wants to merge 7 commits intoshenxn:masterfrom
Conversation
IllusoryKitsune
pushed a commit
to IllusoryKitsune/protonmail-bridge-docker
that referenced
this pull request
Apr 15, 2026
build.yaml: drop tags from the per-platform push step (they conflict with push-by-digest=true,push=true and cause all master-branch matrix jobs to fail on GHCR). The merge job already creates the :build and :<version>-build tags via buildx imagetools create. Also drop linux/arm/v7 from the matrix: proton-bridge's CGO deps (libfido2/cbor) don't cross-compile cleanly on 32-bit ARM and upstream doesn't target it. build/Dockerfile: add runtime libfido2-1 and libcbor0.10 (dynamically linked by the built binaries, previously missing), add pkg-config to the build stage (CGO needs it to find .pc files), add procps for the healthcheck, and add a HEALTHCHECK so orchestrators detect a crashed bridge. Pulled from shenxn#149, shenxn#134, shenxn#128. build/entrypoint.sh, deb/entrypoint.sh: remove stale /root/.gnupg/ S.gpg-agent* sockets on startup (fixes bridge failing to start after a container restart) and harden socat with fork,reuseaddr and nodelay for more reliable port forwarding. Pulled from shenxn#134. README.md: drop arm/v7 from the supported platforms list.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses stability issues where the bridge became unresponsive after running for several days. It introduces two key fixes:
Improved Stdin Persistence: Replaced the previous pipe method with sleep infinity > faketty &. The old method was fragile over long uptimes; this change ensures stdin stays open indefinitely, preventing the bridge from detaching or quitting unexpectedly.
Stale Socket Cleanup: Added a pre-flight check to remove leftover S.gpg-agent sockets on startup. This prevents authentication failures when the container restarts.