Open
Conversation
- enable gpg protection - remove set -x to prevent logging password - add checks to prevent re-initing pass and gpg - present passphrase unlock via docker env variable - Note: gpg-agent will not expire gpg-present-passphrases - fix deb CMD to ENTRYPOINT
lethedata
force-pushed
the
secure-gpg
branch
from
00d365b to
c2e8b88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables secure GPG via a new KEYRING_PASSPHRASE variable. This variable is used as the passphrase for generating gpg key and when reading gpg files. This prevents secrets from being saved in docker volumes without protection.