Added --plain --no-chars and --no-position toggles#154
Merged
sharkdp merged 6 commits intosharkdp:masterfrom May 22, 2022
Merged
Added --plain --no-chars and --no-position toggles#154sharkdp merged 6 commits intosharkdp:masterfrom
--plain --no-chars and --no-position toggles#154sharkdp merged 6 commits intosharkdp:masterfrom
Conversation
Closed
mkatychev
commented
Apr 22, 2022
fa737c5 to
c7ba1fa
Compare
Owner
|
Before I proceed to review this: how does this integrate with what is being proposed in #149? |
Contributor
Author
This PR does not toggle separators or modify existing border behaviour, it allows the toggling of the character table (on the right) and the hex position (on the right).
|
sharkdp
reviewed
May 21, 2022
sharkdp
reviewed
May 21, 2022
sharkdp
reviewed
May 21, 2022
sharkdp
reviewed
May 21, 2022
sharkdp
reviewed
May 21, 2022
sharkdp
reviewed
May 21, 2022
sharkdp
reviewed
May 21, 2022
sharkdp
requested changes
May 21, 2022
Owner
sharkdp
left a comment
There was a problem hiding this comment.
Nice! Thank you. Mainly have some questions regrading the command-line interface (option names)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New flags added:
Motivation was mainly for diffing two separate binary files, borders could be removed but char table and position still created a lot of noise.
Output example:
