Fix truncated UDP and JSON bounds checks#3039
Open
TurboTheTurtle wants to merge 1 commit into
Open
Conversation
TurboTheTurtle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The open fuzzing reports describe one-byte out-of-bounds reads on malformed UDP and JSON inputs. The affected code checked the remaining buffer length too loosely before pre-increment reads.
Closes #3035
Closes #3036
Closes #3037
Validation
cc -fsanitize=address -g -I src tests/test_json.c src/json.c -lm -o /tmp/shadowsocks-libev-test-json/tmp/shadowsocks-libev-test-jsongit diff --checkFull CMake configure was not run locally because the checkout host is missing mbedTLS.