add sasa.c#15
Open
sasai3 wants to merge 2 commits into
Open
Conversation
akkyie
reviewed
Jan 17, 2019
| int fdescript; | ||
| ssize_t readbytes; | ||
| ssize_t writebytes; | ||
| char buf[1024]; |
Member
There was a problem hiding this comment.
1024 みたいなマジックナンバーはstatic constか#defineにしたいね
akkyie
reviewed
Jan 17, 2019
|
|
||
| int main(int argc, char * argv[]){ | ||
| int fdescript; | ||
| ssize_t readbytes; |
akkyie
reviewed
Jan 17, 2019
| fdescript = open(argv[i], O_RDONLY); | ||
| if (fdescript == -1) | ||
| continue; | ||
| } |
Member
There was a problem hiding this comment.
インデントが揃っていなくてわかりにくいけど、"引数を複数指定したら最初に開けたファイルを出力する"という仕様になっているっぽい？
オリジナルのcatの仕様（となぜcatという名前がついているか）を確認してみるといいかも
akkyie
reviewed
Jan 17, 2019
| writebytes = write(1,buf,readbytes); | ||
| } else if (readbytes == 0) { | ||
| close(fdescript); | ||
| writebytes = write(1,"\n",1); |
Member
There was a problem hiding this comment.
writebytesは代入しているけど使っていないのかな？
書き込み失敗した時のエラーハンドリングもしたいところですね
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.