Open
Conversation
Contributor
Author
|
Hi everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #441
Problem
When a configuration method has a params array parameter (e.g. params string[] ids) and the Args section is omitted entirely from config, the library fails to invoke the method at startup with:
System.ArgumentException: Object of type 'System.DBNull' cannot be converted to type 'System.String[]'.
This happens because:
Changes
ConfigurationReader.cs
internal to allow direct unit testing
ConfigurationReaderTests.cs
Root cause
In .NET 10, params parameters report HasDefaultValue = true but DefaultValue is DBNull — not a valid value for an array type. The fix intercepts params parameters before falling through to return parameter.DefaultValue.