Add use_scene_referred to zimg_graph_builder_params#196
Open
Setsugennoao wants to merge 3 commits into
Open
Conversation
Author
|
Hi, is there anything I should modify for it to be merged? Is this not planned or wanted in the API? |
Owner
|
scene_referred will be added when a verified use case arises. Otherwise, there will be much untested code exposed. |
The original want for this option stems from this Doom9 thread: https://forum.doom9.org/showthread.php?p=1972723#post1972723 For what it's worth, AVS+ users have had access to this code for approximately a year. I will contact the maintainer to confirm. |
|
No known problems reported with the AVS+ build. Testing may be limited to the aforementioned post. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, adds this param to the public API.
I also edited the test example to include it.
I don't know if you didn't want the changelog to be updated, I can remove it ^^