Chore: bump dependencies after security alerts#453
Open
Conversation
frameworks-volunteer
approved these changes
Apr 14, 2026
Collaborator
frameworks-volunteer
left a comment
There was a problem hiding this comment.
Model: z-ai/glm-5.1 Reasoning: medium Provider: openrouter
Security + QA review of dependency bump PR.
Security -- PASS
- No hardcoded secrets, tokens, or API keys
- No injection vectors, unsafe eval, or deserialization issues
- All bumps address legitimate CVEs:
- axios 1.14.0 patches proto DoS in mergeConfig
- vite bump patches WebSocket arbitrary file read (notably relevant since --host 0.0.0.0 is in use)
- hono patches static path authorization bypass via encoded slashes
- dompurify patches mutation-XSS via re-contextualization
- brace-expansion patches zero-step sequence hang
- picomatch patches method injection in POSIX character classes
- @types/exceljs removal is correct (deprecated; exceljs ships own types)
QA -- PASS
- Only 2 files changed (package.json + pnpm-lock.yaml), clean deps-only PR
- CI checks pass (lint, sidebar-reminder, Cloudflare Pages)
- @aws-sdk/client-s3 and lib-storage pinned to exact 3.1024.0 (caret removed) -- resolves vulnerable transitive fast-xml-parser
- axios pinned to exact 1.14.0 (not 1.14.1 which had the supply chain issue) -- correct choice
- cspell pinned to exact 9.8.0 -- resolves vulnerable transitive flatted
Note on pinning strategy: Caret ranges were removed from the bumped deps, pinning them to exact versions. This is reasonable for security-motivated bumps to prevent silently drifting to a new major that reintroduces vulns. Future feature bumps can restore the caret if desired.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the dependency updated:
Frameworks PR Checklist
Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:
vocs.config.tsadding thedev: trueparameter