Increase cmake version, avoid printing debugging values (do not pull automatically!)#161
Open
meilof wants to merge 17 commits intoscipr-lab:masterfrom
Open
Increase cmake version, avoid printing debugging values (do not pull automatically!)#161meilof wants to merge 17 commits intoscipr-lab:masterfrom
meilof wants to merge 17 commits intoscipr-lab:masterfrom
Conversation
Setting version to 3.1 enables using CMAKE_PREFIX_PATH to specify pkg-config locations (see https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L115). This heps for example on Mac OS X if you want to provide a location for libcrypto. With this patch I was able to compile libsnark with "cmake .. -DCMAKE_PREFIX_PATH=/usr/local/Cellar/openssl/1.0.2s -DWITH_PROCPS=OFF -DWITH_SUPERCOP=OFF"
meilof
changed the title
Author
|
Hmm, I see now you should not merge this pull request directly because it will also change the reference to libff (to a version that I also patched to remove debugging output)! |
meilof
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting version to 3.1 enables using CMAKE_PREFIX_PATH to specify pkg-config locations (see https://github.com/Kitware/CMake/blob/master/Modules/FindPkgConfig.cmake#L115). This heps for example on Mac OS X if you want to provide a location for libcrypto. With this patch I was able to compile libsnark with
"cmake .. -DCMAKE_PREFIX_PATH=/usr/local/Cellar/openssl/1.0.2s -DWITH_PROCPS=OFF -DWITH_SUPERCOP=OFF"