Skip to content

Fix various warnings (unused, implicits, match)#2429

Merged
bjaglin merged 1 commit intoscalacenter:mainfrom
kitbellew:2429
Apr 22, 2026
Merged

Fix various warnings (unused, implicits, match)#2429
bjaglin merged 1 commit intoscalacenter:mainfrom
kitbellew:2429

Conversation

@kitbellew
Copy link
Copy Markdown
Contributor

No description provided.

@kitbellew kitbellew force-pushed the 2429 branch 3 times, most recently from 723a94b to 7aefbb5 Compare April 22, 2026 17:14
@kitbellew kitbellew marked this pull request as ready for review April 22, 2026 18:22
@kitbellew
Copy link
Copy Markdown
Contributor Author

@bjaglin couldn't fix all of them (and some are from integrations which could be intentional).

Copy link
Copy Markdown
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was your goal to enable -XFatal-warnings to remove warts?

There is a potentially more impactful journey I barely started long time ago with #1744, in order to identify feature gaps as the scalameta trees evolved. I will probably throw an agent at it some time this year.

@bjaglin
Copy link
Copy Markdown
Collaborator

bjaglin commented Apr 22, 2026

Thanks, was your goal to enable -XFatal-warnings to remove warts?

sorry I missed the Wconf

@bjaglin bjaglin merged commit 536101a into scalacenter:main Apr 22, 2026
9 checks passed
@kitbellew
Copy link
Copy Markdown
Contributor Author

Thanks, was your goal to enable -XFatal-warnings to remove warts?

that would be nice. i had a simpler, purely "egotistical" motivation: while working on the OrganizeImports problem, i would run tests locally and then would have to scroll through lots and lots of warnings, to find the needle (error) in that haystack. so i decided to clean it up a little :)

@kitbellew kitbellew deleted the 2429 branch April 22, 2026 19:41
@kitbellew kitbellew changed the title Fix various earnings (unused, implicits, match) Fix various warnings (unused, implicits, match) Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants