fix(parser): support non-standard SCM connection strings (fixes #1645)#1650
Open
arnavsharma990 wants to merge 3 commits intoscalacenter:mainfrom
Open
fix(parser): support non-standard SCM connection strings (fixes #1645)#1650arnavsharma990 wants to merge 3 commits intoscalacenter:mainfrom
arnavsharma990 wants to merge 3 commits intoscalacenter:mainfrom
Conversation
Removed comments for different SCM protocols in tests.
tgodzik
reviewed
Mar 5, 2026
| ) | ||
|
|
||
| def parse(scmInfo: String): Option[Project.Reference] = | ||
| def parseRawConnection(scmInfo: String): Option[Project.Reference] = |
Collaborator
There was a problem hiding this comment.
Isn't this just a rename? Where is the actual fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Issue #1645 where projects using
sbt-ci-releasewere not being indexed because their generated POMs used a shorthand SCM connection format (scm:git@...instead ofscm:git:git@...).Changes
ScmInfoParser.scala: Modified the regex to make the provider field (git:) optional.parsetoparseRawConnectionto better describe its function.ScmInfoParserTests.scalato ensurescm:git@github.com:...is parsed correctly.Verification
Ran the relevant test suite locally:
sbt "data/testOnly scaladex.data.cleanup.ScmInfoParserTests"Result: All tests passed.