Skip to content

fix: remove mancpn file checks for epic installations #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mircearoata merged 2 commits into from
May 12, 2026
Merged

fix: remove mancpn file checks for epic installations #352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
140e337
fix: ignore but warn on missing mancpn file
ReeceXW May 12, 2026
d8306c9
fix: remove the mancpn file checks completely
ReeceXW May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions backend/installfinders/launchers/epic/epic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,11 @@ import (
type Manifest struct {
CatalogNamespace string `json:"CatalogNamespace"`
CatalogItemID string `json:"CatalogItemID"`
ManifestLocation string `json:"ManifestLocation"`
InstallationGUID string `json:"InstallationGUID"`
MainGameAppName string `json:"MainGameAppName"`
AppVersionString string `json:"AppVersionString"`
InstallLocation string `json:"InstallLocation"`
}

type GameManifest struct {
AppName string `json:"AppName"`
CatalogNamespace string `json:"CatalogNamespace"`
CatalogItemID string `json:"CatalogItemID"`
}

var (
EarlyAccessAppName = "CrabEA"
ExperimentalAppName = "CrabTest"
Expand Down Expand Up @@ -86,30 +78,6 @@ func FindInstallationsEpic(epicManifestsPath string, launcher string, platform c

installLocation := platform.ProcessPath(epicManifest.InstallLocation)

gameManifestName := fmt.Sprintf("%s.mancpn", epicManifest.InstallationGUID)
gameManifestPath := platform.ProcessPath(filepath.Join(epicManifest.ManifestLocation, gameManifestName))
gameManifestData, err := os.ReadFile(gameManifestPath)
if err != nil {
findErrors = append(findErrors, fmt.Errorf("failed to read Epic game manifest %s: %w", gameManifestName, err))
continue
}

var epicGameManifest GameManifest
if err := json.Unmarshal(gameManifestData, &epicGameManifest); err != nil {
findErrors = append(findErrors, fmt.Errorf("failed to parse Epic game manifest %s: %w", gameManifestName, err))
continue
}

if epicGameManifest.CatalogNamespace != epicManifest.CatalogNamespace ||
epicGameManifest.CatalogItemID != epicManifest.CatalogItemID ||
epicGameManifest.AppName != epicManifest.MainGameAppName {
findErrors = append(findErrors, common.InstallFindError{
Path: installLocation,
Inner: fmt.Errorf("mismatching manifest data"),
})
continue
}

existingIdx := -1
for i := range installs {
if installs[i].Path == installLocation {
Expand Down
Loading