Conversation
Python 3.14 replaced the bundled zlib with zlib-ng on Windows and added a new _zstd extension. PCbuild expects sources at externals/zlib-ng-2.2.4 and externals/zstd-1.5.7; without them MSBuild fails on zlib-ng.vcxproj when reading zlib.h.in. Add a zlib-ng entry to python-versions.json and wire two new update_zlib_ng / update_zstd helpers into the Windows build_python step so both archives are downloaded, extracted, flattened, and recorded in externals.spdx.json before MSBuild runs.
Linux: build_zstd was installing only libzstd.a, but curl's configure detects libzstd via -lzstd and links libcurl.so against it. Without libzstd.so the curl tool link fails on undefined ZSTD_* symbols. Build both the static and shared libraries and install both, alongside the .pc and headers. Use the lib/Makefile's `lib` target and avoid setting LDFLAGS on the make command line so it doesn't clobber the target-local `LDFLAGS += -shared` rule. 3.14 verify: pygit2 1.16.0 has no cp314 wheels and pygit2's source build needs libgit2 (which we don't ship), so test_install_with_target_* fail on every platform for 3.14. Bump the 3.14 branch to pygit2==1.19.2 and cffi==2.0.0 (pygit2 1.19.2 requires cffi>=2.0); both have cp314 wheels for Linux, macOS, and Windows.
twangboy
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.