fix: preserve query revision for non-reusable interned values#1180
Merged
MichaReiser merged 1 commit intoJun 22, 2026
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
Merging this PR will improve performance by 4.12%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | amortized[SupertypeInput] |
3 µs | 2.8 µs | +4.12% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing MichaReiser:fix-interned-query-stamp (921b43d) with master (4c8b154)
8e4d8e7 to
6cbf9f1
Compare
6cbf9f1 to
921b43d
Compare
Contributor
Author
|
I'll merge this, just in case we make a release because the current Salsa version is kind of broken :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-reusable interned values can omit their dependency edge, but their allocation or reuse revision must still contribute to the creating query. Otherwise, recreating a reusable key as a stable key can move changed_at backwards and trigger a backdating panic.