Skip to content

fix: preserve query revision for non-reusable interned values#1180

Merged
MichaReiser merged 1 commit into
salsa-rs:masterfrom
MichaReiser:fix-interned-query-stamp
Jun 22, 2026
Merged

fix: preserve query revision for non-reusable interned values#1180
MichaReiser merged 1 commit into
salsa-rs:masterfrom
MichaReiser:fix-interned-query-stamp

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Non-reusable interned values can omit their dependency edge, but their allocation or reuse revision must still contribute to the creating query. Otherwise, recreating a reusable key as a stable key can move changed_at backwards and trigger a backdating panic.

@netlify

netlify Bot commented Jun 22, 2026

Copy link
Copy Markdown

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 921b43d
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/6a38dcd784e43f00089ba72d

@codspeed-hq

codspeed-hq Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 4.12%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 39 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation amortized[SupertypeInput] 3 µs 2.8 µs +4.12%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing MichaReiser:fix-interned-query-stamp (921b43d) with master (4c8b154)

Open in CodSpeed

@MichaReiser MichaReiser force-pushed the fix-interned-query-stamp branch from 8e4d8e7 to 6cbf9f1 Compare June 22, 2026 06:55
@MichaReiser MichaReiser force-pushed the fix-interned-query-stamp branch from 6cbf9f1 to 921b43d Compare June 22, 2026 06:57
@MichaReiser

Copy link
Copy Markdown
Contributor Author

I'll merge this, just in case we make a release because the current Salsa version is kind of broken :)

@MichaReiser MichaReiser marked this pull request as ready for review June 22, 2026 07:05
@MichaReiser MichaReiser added this pull request to the merge queue Jun 22, 2026
Merged via the queue into salsa-rs:master with commit 6132b1b Jun 22, 2026
16 checks passed
@MichaReiser MichaReiser deleted the fix-interned-query-stamp branch June 22, 2026 07:10
@github-actions github-actions Bot mentioned this pull request Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant