Add support for BBAN credit transfers#112
Open
olleolleolle wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reformulation of #101 - with fewer changes in the same Pull Request.
This PR adds support for credit transfer transactions to BBAN accounts.
This improves support for Swedish users who may not have user accounts in IBAN format.
Details
Here's a short list of what changes have been included.
IBANValidator: an empty IBAN is not checked within this validator, but is checked as a separate concern.Account: validate presence ofiban.Transaction: validateibanorbbanbeing present.Transactiongains a few new attributes to support BBAN account numbers, and how to express them.:bbanfor things like Swedish Bankgiro, in the form 5748964.:bban_proprietaryfor naming the kind of BBAN account (defaults toBBAN), e.g.BGNR.:clearing_codee.g. SESBA (Sweden Bankgiro Clearing Code).:clearing_bank_identifiere.g. 9900 (clearing number for transactions with BankGiro, Bankgirocentralen (BGC)) or 9960 (clearing number for transactions with Plusgiro).The files that were created in tests were validated with the proprietary SEB Test Bench.