Skip to content

Drop Saleor 3.20 support#2342

Draft
lkostrowski wants to merge 1 commit into
mainfrom
drop-320
Draft

Drop Saleor 3.20 support#2342
lkostrowski wants to merge 1 commit into
mainfrom
drop-320

Conversation

@lkostrowski
Copy link
Copy Markdown
Member

@lkostrowski lkostrowski commented Apr 23, 2026

Saleor 3.20 being EOL, apps are now supporting 3.21 and higher (this is quarterly chore)

Copilot AI review requested due to automatic review settings April 23, 2026 08:13
@lkostrowski lkostrowski requested a review from a team as a code owner April 23, 2026 08:13
@lkostrowski lkostrowski requested a review from magul April 23, 2026 08:13
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026

🦋 Changeset detected

Latest commit: 72f974d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
saleor-app-klaviyo Minor
saleor-app-avatax Minor
saleor-app-search Minor
saleor-app-smtp Minor
saleor-app-cms Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
saleor-app-avatax Ready Ready Preview, Comment Apr 23, 2026 8:15am
saleor-app-cms Ready Ready Preview, Comment Apr 23, 2026 8:15am
saleor-app-klaviyo Ready Ready Preview, Comment Apr 23, 2026 8:15am
saleor-app-payment-np-atobarai Ready Ready Preview, Comment Apr 23, 2026 8:15am
saleor-app-payment-stripe Ready Ready Preview, Comment Apr 23, 2026 8:15am
saleor-app-products-feed Ready Ready Preview, Comment Apr 23, 2026 8:15am
saleor-app-search Ready Ready Preview, Comment Apr 23, 2026 8:15am
saleor-app-segment Ready Ready Preview, Comment Apr 23, 2026 8:15am
saleor-app-smtp Ready Ready Preview, Comment Apr 23, 2026 8:15am

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates app manifests to drop compatibility with Saleor 3.20 (EOL) by bumping the minimum required Saleor version to 3.21 across the remaining apps that still declared 3.20 support.

Changes:

  • Bump requiredSaleorVersion from >=3.20 <4 to >=3.21 <4 in multiple app manifests.
  • Add a changeset covering the version bump for the affected app packages.
  • Update Klaviyo manifest to use a type-only import for AppManifest.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
apps/smtp/src/pages/api/manifest.ts Raises minimum Saleor version to 3.21 in SMTP app manifest.
apps/search/src/pages/api/manifest.ts Raises minimum Saleor version to 3.21 in Search app manifest.
apps/klaviyo/src/pages/api/manifest.ts Raises minimum Saleor version to 3.21; converts AppManifest import to type-only.
apps/cms/src/pages/api/manifest.ts Raises minimum Saleor version to 3.21 in CMS app manifest.
apps/avatax/src/app/api/manifest/route.ts Raises minimum Saleor version to 3.21 in AvaTax app manifest.
.changeset/nine-chefs-stare.md Declares release bumps for the affected app packages.

Comment thread .changeset/nine-chefs-stare.md
Comment thread apps/smtp/src/pages/api/manifest.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.83%. Comparing base (af75011) to head (72f974d).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
apps/avatax/src/app/api/manifest/route.ts 0.00% 1 Missing ⚠️
apps/cms/src/pages/api/manifest.ts 0.00% 1 Missing ⚠️
apps/search/src/pages/api/manifest.ts 0.00% 1 Missing ⚠️
apps/smtp/src/pages/api/manifest.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2342   +/-   ##
=======================================
  Coverage   37.83%   37.83%           
=======================================
  Files        1037     1037           
  Lines       66920    66920           
  Branches     3526     3526           
=======================================
  Hits        25320    25320           
  Misses      41219    41219           
  Partials      381      381           
Flag Coverage Δ
avatax 57.58% <0.00%> (ø)
cms 20.36% <0.00%> (ø)
domain 100.00% <ø> (ø)
dynamo-config-repository 79.29% <ø> (ø)
errors 91.66% <ø> (ø)
logger 28.81% <ø> (ø)
np-atobarai 72.58% <ø> (ø)
products-feed 6.00% <ø> (ø)
search 31.88% <0.00%> (ø)
segment 33.58% <ø> (ø)
shared 55.43% <ø> (ø)
smtp 35.74% <0.00%> (ø)
stripe 70.83% <ø> (ø)
webhook-utils 11.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@magul
Copy link
Copy Markdown
Member

magul commented Apr 23, 2026

Shouldn't we wait with merging this pull request until we will get rid of 3.20 from the Cloud?

@lkostrowski
Copy link
Copy Markdown
Member Author

Shouldn't we wait with merging this pull request until we will get rid of 3.20 from the Cloud?

Yea good catch, 3.20 is EOL but we still have some cloud leftovers.

I will revisit this in a month

@lkostrowski lkostrowski marked this pull request as draft April 23, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants