Conversation
75be541 to
ccdd17c
Compare
Owner
Author
|
/code pr |
saidsef
commented
Mar 10, 2026
Owner
Author
saidsef
left a comment
There was a problem hiding this comment.
🤖
The changes to conditionally output an empty string when the module is disabled are necessary and correct. This prevents Terraform from attempting to reference a non-existent resource when var.enabled is false, which would cause an error. The ternary expressions are properly formatted and maintain type consistency (strings).
> deepseek-reasoner [pr | 1]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor improvement to the output handling in the Terraform module. The change ensures that the
role_idandrole_arnoutputs return empty strings when the module is disabled, preventing potential errors or confusion.role_idandrole_arnoutputs inoutputs.tfso they return empty strings ifvar.enabledis false.