Open
Conversation
saidsef
added
python
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -5 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
saidsef
changed the title
saidsef
changed the title
Dependency ReviewThe following issues were found:
License Issuespyproject.toml
requirements.txt
uv.lock
OpenSSF ScorecardScorecard details
Scanned Files
|
saidsef
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
saidsef
force-pushed
the
python-3.14-upgrade
branch
from
98aa24b to
e7dd2c7
Compare
saidsef
force-pushed
the
python-3.14-upgrade
branch
from
e7dd2c7 to
e749893
Compare
saidsef
dismissed
github-actions[bot]’s stale review
The merge-base changed after approval.
saidsef
force-pushed
the
python-3.14-upgrade
branch
from
08271e7 to
cd12d13
Compare
saidsef
changed the title
saidsef
force-pushed
the
python-3.14-upgrade
branch
from
ebb98f4 to
6c0fe61
Compare
saidsef
force-pushed
the
python-3.14-upgrade
branch
from
57b39d6 to
04b4e99
Compare
…ve requests dependency Upgrades the project to Python 3.14. - Dropped `requests` in favour of `httpx` - Replaced `mypy` with `pyright` - Updated authlib to 1.7.0 (fixes GHSA-jj8c-mmj3-mmgv) - TypedDicts rewritten as PEP 695 functional type aliases - `inspect.isroutine()` instead of `ismethod()`/`isfunction()` for Python 3.14 compatibility - Removed `ResponseCachingMiddleware` which caused `tools/list` failure in FastMCP 3.2.4
saidsef
force-pushed
the
python-3.14-upgrade
branch
from
04b4e99 to
79791ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Upgrades the project to Python 3.14. The
.python-versionandDockerfilealready targeted 3.14 — this brings the rest of the project in sync and cleans up patterns that accumulated as the project grew from 3.9 → 3.12 → 3.14.Dependency changes
requestsin favour ofhttpx(which was already the only HTTP client used byfastmcp)mypywithpyright—fastmcpitself ships pyright-compatible stubs, and pyright handles PEP 695 syntax betterfastmcp[apps]anduvTyping
Optional[X]→X | None,Dict[K, V]→dict[K, V]throughouttype X = TypedDict(...))Code cleanup
IPIntegration.__init__simplified: 12 lines → 2 usingorfallbacksIPIntegration.get_ipv6_infonow uses a context manager for the httpx client and drops theurllib3monkey-patch_PermissiveGitHubProvidermoved to module level (was defined insideget_oauth_verifier())add_pr_commentscalledhttpx.getwith ajson=kwarg (should behttpx.post)What might break
requestsdirectly via this package will break (none in-tree)Bugs fixed during review
Tool registration broken in Python 3.14
The
register_tools()method usedinspect.ismethod()to detect bound methods, but Python 3.14 changed the behavior — bound methods now returnFalse. This caused all 20 MCP tools to be silently skipped during registration.Fix: Changed
inspect.isfunction(method) or inspect.ismethod(method)→inspect.isroutine(method)which works for both.ResponseCachingMiddleware causing tools/list to fail
The
ResponseCachingMiddlewarewas added withttl=0to disable caching, but FastMCP 3.2.4 rejectsttl=0as invalid, causing everytools/listrequest to fail with "TTL is invalid" error.Fix: Removed the middleware entirely since tool list changes are detectable via the
listChangedcapability.