feat(setup): switch default tunnel to ngrok - #39
Merged
Conversation
…nto codex/cloudflare-oauth-tunnel # Conflicts: # scripts/setup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gordie initto detectngrok, offer Homebrew installation when missing, configure the authtoken, and briefly start ngrok to discover the account dev-domain URL..env.examplearound ngrok authtokens, stable dev domains, and the Docker connector target.Test Coverage
All new setup paths have focused unit coverage:
ngrokwith install declined falls back to manual URL/authtoken prompts.ngrokcan configure an authtoken, discover a dev-domain URL, and write.env.ngrokconnector withNGROK_AUTHTOKEN.Pre-Landing Review
No remaining issues found. One validation gap found during review,
https://localhostbeing accepted as "public HTTPS", was fixed before push.Design Review
No frontend files changed.
Eval Results
No prompt-related files changed.
Greptile Review
Greptile comment fetch was unavailable due a GitHub API connectivity error during review.
Plan Completion
No plan file detected.
Verification Results
uv run ruff check scripts/setup.py server/oauth_config.py server/oauth_link_service.py server/routes/oauth_routes.py tools/oauth/generate_oauth_link.py tests/unit/test_setup_cli.py tests/unit/test_oauth_link_service.py tests/unit/test_generate_oauth_link_tool.pyuv run basedpyright scripts/setup.py server/oauth_config.py server/oauth_link_service.py tools/oauth/generate_oauth_link.py tests/unit/test_setup_cli.py tests/unit/test_oauth_link_service.py tests/unit/test_generate_oauth_link_tool.pyuv run pytest tests/unit/test_setup_cli.py tests/unit/test_oauth_link_service.py tests/unit/test_generate_oauth_link_tool.pydocker compose config --servicesuv run gordie init --helpgit diff --checkruff,basedpyright, andpytestsuite: 336 passed, 1 warningTODOS
No
TODOS.mdfile exists in this repository.Test plan