-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add WatchLock to coordinate rebuilds with external readers #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4b30084
Add `Watch::run_with_hooks`
yozhgoor af2f25c
Replace `run_with_hooks` by `run_with_lock`
yozhgoor b3d3d15
Improve lock API
yozhgoor 9f19a6a
Clean up
yozhgoor f64c164
Replace `Mutex` by `RwLock`
yozhgoor 4b96dd4
Update documentation
yozhgoor c669440
Rename `Lock` in `WatchLock`
yozhgoor c79ed5c
After review
yozhgoor 06025aa
Remove closure
yozhgoor 53bf865
Add `WatchMsg` to differentiate file changes and build statuses
yozhgoor b1c881a
CLEANUP
cecton 2d369d4
Avoid building if the command succeeded
cecton 39f0033
CLEANUP
cecton 7a9ac46
CLEANUP
cecton ba22920
Fix race condition with generation counter for WatchLock
cecton 676b1bd
Document that Watch::run() holds the write lock immediately on start
cecton d8104fb
Update stale version in crate-level doc example
cecton 1a3d1af
Add WatchLock discoverability note to Watch struct doc
cecton 393d3da
Document lock poisoning handling: unwrap_or_else for WatchLock, clari…
cecton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.