nostr: add more NIP-specific builders

[yukibtc]

Checklist

• I followed the contribution guidelines
• I updated the CHANGELOG (if applicable)
• I personally wrote and understood all code in this PR

[codecov]

Codecov Report

❌ Patch coverage is 69.36937% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.51%. Comparing base (ff5be7d) to head (82b5668).

Files with missing lines	Patch %	Lines
crates/nostr/src/event/builder.rs	25.00%	18 Missing ⚠️
crates/nostr/src/nips/nip88.rs	0.00%	4 Missing ⚠️
crates/nostr/src/nips/nip34.rs	75.00%	3 Missing ⚠️
crates/nostr/src/nips/nip35.rs	0.00%	2 Missing ⚠️
crates/nostr/src/nips/nipb0.rs	0.00%	2 Missing ⚠️
crates/nostr/src/nips/nipc0.rs	0.00%	2 Missing ⚠️
rfs/nostr-blossom/src/bud01.rs	0.00%	2 Missing ⚠️
crates/nostr/src/nips/nip17.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
+ Coverage   72.44%   72.51%   +0.07%     
==========================================
  Files         202      202              
  Lines       33143    33138       -5     
==========================================
+ Hits        24011    24031      +20     
+ Misses       9132     9107      -25     

Flag	Coverage Δ
rust	72.51% <69.36%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[TheAwiteb]

ACK.

I see why you added the Error type to the traits. But I really think it should be handled by the builder and not the trait. For example, the issue builder should not take an invalid coordinate in the first place.

#1358 (comment)

[TheAwiteb]

But I really think it should be handled by the builder and not the trait. For example, the issue builder should not take an invalid coordinate in the first place.

Something like this

pub struct GitIssue {
    /// The repository address
    repository: Coordinate,
    /// The issue content (markdown)
    content: String,
    /// Subject
    subject: Option<String>,
    /// Labels
    labels: Vec<String>,
}

pub struct GitIssueBuilder {
    /// The repository address
    pub repository: Coordinate,
    /// The issue content (markdown)
    pub content: String,
    /// Subject
    pub subject: Option<String>,
    /// Labels
    pub labels: Vec<String>,
}

impl GitIssueBuilder {
    pub fn new(repository: Coordinate, content: String) -> Self {
        Self {
            repository,
            content,
        }
    }

    // .. reset of the functions, like `subject`, `label`, `extend_labels` and `label`

    pub fn build(self) -> Result<GitIssue, Error> {
        // Check here

        Ok(GitIssue {
            // ..
        })
    }
}

// Impl the finalizer to `GitIssue`

[TheAwiteb]

perhaps we can use https://bon-rs.com for this? https://crates.io/crates/bon

---

Check this https://bon-rs.com/guide/patterns/fallible-builders

pub struct User {
    id: u32,
    name: String,
}

#[bon]
impl User {
    #[builder]
    pub fn new(id: u32, name: String) -> Result<Self, Error> {
        if name.is_empty() {
            return Err(anyhow::anyhow!("Empty name is disallowed"));
        }

        Ok(Self { id, name })
    }
}

// The `build()` method returns a `Result`
let result = User::builder()
    .id(42)
    .name(String::new())
    .build();

if let Err(error) = result {
    // Handle the error
}