Skip to content

nostr: add NIP-66 kinds and relay discovery tags#1346

Merged
yukibtc merged 1 commit into
rust-nostr:masterfrom
alopatindev:nip-66-kinds
May 16, 2026
Merged

nostr: add NIP-66 kinds and relay discovery tags#1346
yukibtc merged 1 commit into
rust-nostr:masterfrom
alopatindev:nip-66-kinds

Conversation

@alopatindev

@alopatindev alopatindev commented May 1, 2026

Copy link
Copy Markdown
Contributor

Description

  • Add nip66, RelayMonitor, RelayDiscovery, NetworkType, RelayType, Requirement

Checklist

@codecov

codecov Bot commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.22939% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.00%. Comparing base (0a030e1) to head (97d1f81).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/nostr/src/nips/nip66.rs 84.00% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
+ Coverage   70.90%   71.00%   +0.09%     
==========================================
  Files         201      202       +1     
  Lines       33366    33645     +279     
==========================================
+ Hits        23657    23888     +231     
- Misses       9709     9757      +48     
Flag Coverage Δ
rust 71.00% <84.22%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alopatindev alopatindev force-pushed the nip-66-kinds branch 3 times, most recently from d9f78ab to a9c38d1 Compare May 1, 2026 17:55
@alopatindev alopatindev changed the title Draft: nostr: add NIP-66 nostr: add NIP-66 May 1, 2026
@TheAwiteb

Copy link
Copy Markdown
Member

Hi @alopatindev, thank you for your work, but we no longer update the tags until we done this refactor #907. it also block #1216, #1283, #1204, #1321 and #1331

I'll make this PR a draft and you can continue work on it after #907 closed.

@TheAwiteb TheAwiteb marked this pull request as draft May 1, 2026 21:37
@TheAwiteb

Copy link
Copy Markdown
Member

Hi @alopatindev, the tag refactoring in #1347 has been merged, so you can now continue your work 🫡

@alopatindev alopatindev force-pushed the nip-66-kinds branch 6 times, most recently from 85f42c4 to 80b561b Compare May 13, 2026 19:52
Comment thread crates/nostr/src/nips/nip66.rs Outdated
@alopatindev alopatindev marked this pull request as ready for review May 13, 2026 20:35
Comment thread crates/nostr/src/nips/nip66.rs Outdated
@TheAwiteb

Copy link
Copy Markdown
Member

alopatindev marked this pull request as ready for review

I'll do a full review tomorrow, thank you 🫡

@alopatindev alopatindev force-pushed the nip-66-kinds branch 3 times, most recently from 92ff2a0 to 90968ea Compare May 13, 2026 20:53
Comment thread crates/nostr/src/nips/nip66.rs Outdated
Comment thread crates/nostr/src/nips/nip66.rs Outdated
Comment thread crates/nostr/src/nips/nip66.rs Outdated
Comment thread crates/nostr/src/nips/nip66.rs Outdated
Comment thread crates/nostr/src/nips/nip66.rs Outdated
Comment thread crates/nostr/src/nips/nip66.rs
@alopatindev alopatindev force-pushed the nip-66-kinds branch 2 times, most recently from 7d1f922 to 7b49a86 Compare May 14, 2026 11:55
Comment thread crates/nostr/src/nips/nip66.rs

@TheAwiteb TheAwiteb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, Thank you @alopatindev for the contribution

@yukibtc yukibtc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I've marked few changes to do. I also would rename the commit to something like "nostr: add NIP-66 kinds and relay discovery tags" as this doesn't include the full NIP-66 support (like tags for relay monitor announcement and the event building)

Comment thread crates/nostr/src/nips/mod.rs
Comment thread crates/nostr/src/nips/nip66.rs Outdated
Comment thread crates/nostr/CHANGELOG.md Outdated
Comment thread crates/nostr/src/nips/nip66.rs Outdated
@yukibtc yukibtc changed the title nostr: add NIP-66 nostr: add NIP-66 kinds and relay discovery tags May 15, 2026
@yukibtc yukibtc added this to the v0.45 milestone May 15, 2026
@alopatindev alopatindev force-pushed the nip-66-kinds branch 2 times, most recently from 4868e45 to 5f3f82c Compare May 15, 2026 11:54
@alopatindev

Copy link
Copy Markdown
Contributor Author

I think is_accepted in Requirement sounds weird, let me fix it first.

@alopatindev

Copy link
Copy Markdown
Contributor Author

I think is_accepted in Requirement sounds weird, let me fix it first.

Fixed

@TheAwiteb TheAwiteb requested a review from yukibtc May 15, 2026 20:28
@yukibtc yukibtc merged commit 1432a7e into rust-nostr:master May 16, 2026
47 checks passed
@TheAwiteb

Copy link
Copy Markdown
Member

Thank you @alopatindev, this is a great work 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants