fix(ica): add missing exponential#426
Merged
relf merged 2 commits intorust-ml:masterfrom Dec 22, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 106 106
Lines 7461 7461
=======================================
Hits 5745 5745
Misses 1716 1716 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
relf
approved these changes
Dec 22, 2025
jagan-nuvai
added a commit
to Nuvai/linfa
that referenced
this pull request
Apr 30, 2026
Brings in master's 0.8.1 release work and downstream commits: - 4484a55 Bump all crates 0.8.0 -> 0.8.1 - 59fc6c6 Prepare release 0.8.1 (rust-ml#428) - 54ea637 fix(ica): add missing exponential (rust-ml#426) - 9b5c424 Add AdaBoost classifier to linfa-ensemble (rust-ml#427) - db3cade [Feature] Add Least Angle Regression (rust-ml#421) - Plus website / news / about updates Conflict resolution: 7 Cargo.toml files (linfa-clustering, linfa-hierarchical, linfa-linear, linfa-nn, linfa-preprocessing, linfa-reduction, datasets) had conflicts where master's 0.8.0 -> 0.8.1 version bump landed on lines our branch had ndarray ecosystem version bumps on. Took the union: master's 0.8.1 plus our ndarray 0.17 / rand 0.9 / sprs 0.11.4 / rand_xoshiro 0.7 versions. Migration of merged code to our ndarray 0.17 / rand 0.9 ecosystem: linfa-ensemble (AdaBoost from rust-ml#427) - src/adaboost.rs: distributions::WeightedIndex -> distr::weighted::WeightedIndex - src/adaboost_hyperparams.rs: thread_rng() -> rng() linfa-lars (LARS from rust-ml#421) - Cargo.toml: bumped to ndarray 0.17 / ndarray-linalg 0.18 / ndarray-stats 0.7 / linfa-linalg fork branch / ndarray-rand 0.16 / rand_xoshiro 0.7 - src/algorithm.rs:151: extracted RHS into a let-binding to satisfy the ndarray-0.17 stricter borrow check on `coef.assign(&(... &coef ...))` - src/algorithm.rs:600: Uniform::new() now returns Result, added .unwrap() AdaBoost orphaned pending follow-up - Removed `mod adaboost;` and `mod adaboost_hyperparams;` from linfa-ensemble/src/lib.rs (sources stay on disk for the follow-up PR) - Gated 6 AdaBoost test functions with #[cfg(any())] - Removed AdaBoost section from doc comment - Deleted adaboost_iris example (cannot compile without the public types) - Reason: AdaBoost's `impl Fit for AdaBoostValidParams<P, R>` writes `where P: Fit<...> + Clone`, which under generic P can only be satisfied via Linfa's `ParamGuard` blanket impl. The blanket requires `P: ParamGuard + Clone, P::Checked: Fit, Error: From<P::Error>`, which under ndarray 0.17's reshaped types triggers an infinite trait-solver recursion. Fixing it requires structural rework (likely making AdaBoost take a model factory rather than generic `Fit`-able params). Out of scope for this dependency upgrade PR; tracked separately. Verified on x86_64-linux (knuckles-dev VM): cargo check --workspace --all-targets -> exit 0, 0 warnings cargo test --workspace -> 475 passed, 0 failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GFunc::Expcomputes incorrect g and g' derivatives #425Simple fix to the exp variant of fast ICA algo, a missing
.exp()call