Add missing rustbot to the log repository#2531
Merged
Merged
Conversation
Mark-Simulacrum
approved these changes
Jun 22, 2026
Mark-Simulacrum
left a comment
Member
There was a problem hiding this comment.
Hm, this seems fine, but I'd expect us to not try to run handlers if we don't have permissions to do so (or else we need this in every/all repositories, right?)
Member
Author
We current don't do any check permission check, we (maybe naïvely) trust that if a repo has a We do have some exceptions for org-wide features, but it's manual and rely on the same principal (assume rights if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
logrepo has had atriagebot.tomlfor quite some time now, but never gave the permissions to rustbot/triagebot.This is starting to cause some issues for triagebot as we have been trying to update some review comments for a few days. Let's fix the inconsistency by giving
rustbotthe permissions.