Skip to content

Add missing rustbot to the log repository#2531

Merged
Mark-Simulacrum merged 1 commit into
rust-lang:mainfrom
Urgau:log-repo-rustbot
Jun 22, 2026
Merged

Add missing rustbot to the log repository#2531
Mark-Simulacrum merged 1 commit into
rust-lang:mainfrom
Urgau:log-repo-rustbot

Conversation

@Urgau

@Urgau Urgau commented Jun 22, 2026

Copy link
Copy Markdown
Member

The log repo has had a triagebot.toml for quite some time now, but never gave the permissions to rustbot/triagebot.

This is starting to cause some issues for triagebot as we have been trying to update some review comments for a few days. Let's fix the inconsistency by giving rustbot the permissions.

@Mark-Simulacrum Mark-Simulacrum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this seems fine, but I'd expect us to not try to run handlers if we don't have permissions to do so (or else we need this in every/all repositories, right?)

@Mark-Simulacrum Mark-Simulacrum added this pull request to the merge queue Jun 22, 2026
Merged via the queue into rust-lang:main with commit a09d0e0 Jun 22, 2026
4 checks passed
@Urgau

Urgau commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

I'd expect us to not try to run handlers if we don't have permissions to do so (or else we need this in every/all repositories, right?)

We current don't do any check permission check, we (maybe naïvely) trust that if a repo has a triagebot.toml that it has the right permissions.

We do have some exceptions for org-wide features, but it's manual and rely on the same principal (assume rights if triagebot.toml file present).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants