Add target checking to #[register_tool]#157377
Merged
rust-bors[bot] merged 1 commit intoJun 4, 2026
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
target-register-tool
branch
from
10dede4 to
2a28ba8
Compare
This comment has been minimized.
This comment has been minimized.
mejrs
reviewed
Jun 3, 2026
Comment on lines
+107
to
110
| #[register_tool(xyz)] | ||
| //~^ WARN crate-level attribute should be an inner attribute | ||
| unreachable!(); | ||
| } |
Contributor
There was a problem hiding this comment.
Can this be an error? I notice crate level attrs are basically allowed anywhere, I'd like that not to be the case with a new crate level attribute if I can help it.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
The reason that this is a warning is because it historically was. When we initially wrote the attribute parsers the first goal was preserving behavior. I think it makes sense to change this tho, and I think the time has come that for all unstable attributes we should change this. I'll open a PR tomorrow |
Contributor
|
📋 This PR cannot be approved because it has merge conflicts. Please resolve the conflicts and try again. |
mejrs
added
S-waiting-on-author
JonathanBrouwer
force-pushed
the
target-register-tool
branch
from
2a28ba8 to
957e505
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=mejrs |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 5, 2026
…=mejrs Make distinction between crate-level attributes that are warned vs errored r? @mejrs This is a follow-up to rust-lang#157377 (comment) This PR makes all unstable crate-level attributes error on incorrect targets. To make the diff more helpful, I'd recommend reviewing the two commits separately. * The first commit introduces the infra & makes all crate-level attributes a warning, the commit should have no effect * The second commit undoes some changes from the first commit, to make all unstable crate-level attributes error
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 5, 2026
…=mejrs Make distinction between crate-level attributes that are warned vs errored r? @mejrs This is a follow-up to rust-lang#157377 (comment) This PR makes all unstable crate-level attributes error on incorrect targets. To make the diff more helpful, I'd recommend reviewing the two commits separately. * The first commit introduces the infra & makes all crate-level attributes a warning, the commit should have no effect * The second commit undoes some changes from the first commit, to make all unstable crate-level attributes error
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 5, 2026
…=mejrs Make distinction between crate-level attributes that are warned vs errored r? @mejrs This is a follow-up to rust-lang#157377 (comment) This PR makes all unstable crate-level attributes error on incorrect targets. To make the diff more helpful, I'd recommend reviewing the two commits separately. * The first commit introduces the infra & makes all crate-level attributes a warning, the commit should have no effect * The second commit undoes some changes from the first commit, to make all unstable crate-level attributes error
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 5, 2026
…=mejrs Make distinction between crate-level attributes that are warned vs errored r? @mejrs This is a follow-up to rust-lang#157377 (comment) This PR makes all unstable crate-level attributes error on incorrect targets. To make the diff more helpful, I'd recommend reviewing the two commits separately. * The first commit introduces the infra & makes all crate-level attributes a warning, the commit should have no effect * The second commit undoes some changes from the first commit, to make all unstable crate-level attributes error
rust-timer
added a commit
that referenced
this pull request
Jun 5, 2026
Rollup merge of #157443 - JonathanBrouwer:crate-level-err, r=mejrs Make distinction between crate-level attributes that are warned vs errored r? @mejrs This is a follow-up to #157377 (comment) This PR makes all unstable crate-level attributes error on incorrect targets. To make the diff more helpful, I'd recommend reviewing the two commits separately. * The first commit introduces the infra & makes all crate-level attributes a warning, the commit should have no effect * The second commit undoes some changes from the first commit, to make all unstable crate-level attributes error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @mejrs