resolve: Introduce separate (Local,Extern)ModuleData structures for local and external modules respectively#156362
resolve: Introduce separate (Local,Extern)ModuleData structures for local and external modules respectively#156362petrochenkov wants to merge 11 commits intorust-lang:mainfrom
(Local,Extern)ModuleData structures for local and external modules respectively#156362Conversation
… local and external modules respectively
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
resolve: Introduce separate `(Local,Extern)ModuleData` structures for local and external modules respectively
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (aa5ec85): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.9%, secondary 0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 497.416s -> 499.549s (0.43%) |
|
☔ The latest upstream changes (presumably #156361) made this pull request unmergeable. Please resolve the merge conflicts. |
Besides the
CommonModuleDatacore they need to keep quite different data.This is a follow up to #155242.
The remaining piece is dismantling
CommonModuleData::lazy_resolutions, but it would be better done separately.