Clarify the role of the PreCodegen dummy pass#156358
Open
Zalathar wants to merge 2 commits intorust-lang:mainfrom
Open
Clarify the role of the PreCodegen dummy pass#156358Zalathar wants to merge 2 commits intorust-lang:mainfrom
PreCodegen dummy pass#156358Zalathar wants to merge 2 commits intorust-lang:mainfrom
Conversation
This function doesn't have an obvious home, but there's little reason for it to be in `rustc_mir_transform`, and having it in `rustc_driver_impl::pretty` at least puts it near other callers of `write_mir_pretty`.
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing comments for this pass are somewhat confusing.
The
PreCodegenpass does nothing by itself. It exists so that-Zdump-mir(and mir-opt tests) can easily dump the final pre-codegen MIR, by dumping the input or output of PreCodegen, which happens to be run after all other passes are finished.