Skip to content

internal: remove no_lifetime where it's trivial#22602

Closed
ada4a wants to merge 1 commit into
rust-lang:masterfrom
ada4a:push-lrluuvwsnsyk
Closed

internal: remove no_lifetime where it's trivial#22602
ada4a wants to merge 1 commit into
rust-lang:masterfrom
ada4a:push-lrluuvwsnsyk

Conversation

@ada4a

@ada4a ada4a commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Removing these doesn't seem to cause any compilation errors

Removing these doesn't seem to cause any compilation errors
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2026
@ada4a

ada4a commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Also shouldn't conflict with #22548

@Veykril Veykril left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these not used or how come we don't have to adjust any use sites? 🤔

View changes since this review

@ada4a

ada4a commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Are these not used

It would appear so? I admit I haven't looked into it, I will do so now

@Veykril

Veykril commented Jun 19, 2026

Copy link
Copy Markdown
Member

yea this is dead code actually

@ada4a

ada4a commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Ok, I'll open a v2 to remove those completely

@ada4a ada4a closed this Jun 19, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2026
@ada4a ada4a deleted the push-lrluuvwsnsyk branch June 19, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants