Make EscapeError enum non-exhaustive#26
Closed
GuillaumeGomez wants to merge 1 commit into
Closed
Conversation
Member
Shouldn't the |
Member
Author
|
Kinda makes sense. Gonna do that. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 5, 2026
…acro, r=Urgau Create non-exhaustive `proc_macro::EscapeError` enum mirrorring `rustc-literal-escaper`'s As discussed in rust-lang/literal-escaper#26. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 5, 2026
…acro, r=Urgau Create non-exhaustive `proc_macro::EscapeError` enum mirrorring `rustc-literal-escaper`'s As discussed in rust-lang/literal-escaper#26. r? @Urgau
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 5, 2026
Rollup merge of #157442 - GuillaumeGomez:escape-error-proc-macro, r=Urgau Create non-exhaustive `proc_macro::EscapeError` enum mirrorring `rustc-literal-escaper`'s As discussed in rust-lang/literal-escaper#26. r? @Urgau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're in the process of stabilizing the new proc-macro API (rust-lang/rust#151973) making use of this crate. However the
EscapeErrorenum is publicly reexported byproc-macroand it was suggested to make it non-exhaustive to allow to potentially add more variants in the future and I think it's a good idea.cc @Urgau