Skip to content

change benches to using criterion#17

Draft
hkBst wants to merge 1 commit into
rust-lang:mainfrom
hkBst:criterion
Draft

change benches to using criterion#17
hkBst wants to merge 1 commit into
rust-lang:mainfrom
hkBst:criterion

Conversation

@hkBst

@hkBst hkBst commented Jun 25, 2025

Copy link
Copy Markdown
Member

I wanted to try out criterion. So far it's... different.

@hkBst

hkBst commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

Now with an up to date version, somehow the criterion book is still based on an old version.

@tgross35

Copy link
Copy Markdown

Not sure what exactly you're going for but if perf is somewhat touchy in this repo, it might be worth checking out https://github.com/iai-callgrind/iai-callgrind. Nice that results are identical both on CI and locally (it's been running in compiler-builtins for ~6 months and I haven't noticed any noise, e.g. https://github.com/rust-lang/compiler-builtins/actions/runs/15858785039/job/44710523566#step:7:1356)

@hkBst

hkBst commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

Thanks @tgross35. I'll be sure to look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants