Fix unsound compat01as03 implementation (fixes #2514)#3012
Open
stbuehler wants to merge 1 commit into
Open
Conversation
Miri complains: > Undefined Behavior: trying to retag [...] for SharedReadWrite > permission [...], but that tag only grants SharedReadOnly permission for > this location in the UnsafeNotify01::drop_raw implementation for NotifyWaker. drop_raw should receive a `*mut Self`, but that isn't dyn compatible; it receives `&Self` instead (as documented by futures01 UnsafeNotify::drop_raw). Wrap in and access through UnsafeCell to fix the undefined behavior.
rustbot
added
A-compat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miri complains:
in the UnsafeNotify01::drop_raw implementation for NotifyWaker.
drop_raw should receive a
*mut Self, but that isn't dyn compatible; it receives&Selfinstead (as documented by futures01 UnsafeNotify::drop_raw).Wrap in and access through UnsafeCell to fix the undefined behavior.