Make optimize_attribute conditional on libstd#752
Conversation
ChrisDenton
force-pushed
the
optimize_attribute
branch
2 times, most recently
from
146f1dc to
b6337bb
Compare
ChrisDenton
force-pushed
the
optimize_attribute
branch
from
b6337bb to
7cc5b3f
Compare
|
cc @workingjubilee, I'm trying to get CI working again. Does this look ok to you? The alternative is to just allow unused features but it seems like a useful lint. Then again, it's not like I'd expect we'd use many of them. |
|
This seems fine, yes! Will doublecheck something and then merge. |
|
...What were you gonna check, Jubilee? |
| backtrace_in_libstd, | ||
| feature = "backtrace", | ||
| any(unix, all(windows, target_env = "gnu")), | ||
| not(target_vendor = "uwp"), |
There was a problem hiding this comment.
...is windows with gnu and UWP a coherent concept?
anyway the not obtains so we're fine regardless.
There was a problem hiding this comment.
Maybe. I mean, hypothetically at least. We have an x86_64-uwp-windows-gnu target but idk how well all these targets are maintained. Or even if they make any sense. I know the msvc one is used by at least one person because they complain when I break it (though not immediately).
2 participants
This should hopefully fix CI.