Add ExactSizeIterator, FusedIterator, and DoubleEndedIterator on IntoIter types#628
Merged
sgued merged 2 commits intorust-embedded:mainfrom Nov 4, 2025
Merged
Conversation
therealbnut
commented
Nov 3, 2025
| assert_eq!(v, *src.get(k).unwrap()); | ||
| assert_eq!(v, src.remove(k).unwrap()); | ||
| } | ||
| assert!(src.is_empty()); |
Contributor
Author
There was a problem hiding this comment.
Added this check as previously this test would pass if the iterator only returned None.
| for (k, v) in clone.into_iter() { | ||
| assert_eq!(v, src.remove(k).unwrap()); | ||
| } | ||
| assert!(src.is_empty()); |
Contributor
Author
There was a problem hiding this comment.
Added this check as previously this test would pass if the iterator only returned None.
therealbnut
changed the title
sgued
approved these changes
Nov 4, 2025
Contributor
sgued
left a comment
sgued
left a comment
There was a problem hiding this comment.
Thanks for the contribution and the updated tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #626 by implementing missing traits on the
IntoItertypes. Specifically:FusedIteratortovec::IntoIter,deque::IntoIter,index_map::IntoIterandlinear_map::IntoIter.ExactSizeIteratortovec::IntoIter,deque::IntoIter,index_map::IntoIterandlinear_map::IntoIter.DoubleEndedIteratortovec::IntoIteranddeque::IntoIter.I didn't implement
DoubleEndedIteratoron the Map types, as their reference-based iterators didn't have it. Even if there was reference implementations, there wasn't a way to do it that would make sense without changing existing behaviour and/or the structures themselves.