Skip to content

Fix a call to nil on objects to destroy #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shigawire wants to merge 4 commits into
base: core
Choose a base branch
from
+3 −0
Open

Fix a call to nil on objects to destroy #475

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34318e5
Don't call nil-method on object associations
Shigawire Jul 8, 2019
5de9fc6
Merge branch 'core' into fix-nil-error-on-dependency-handling
mathieujobin Mar 23, 2022
b61e83b
Merge branch 'core' into fix-nil-error-on-dependency-handling
mathieujobin Jun 5, 2023
7a00247
Merge branch 'core' into fix-nil-error-on-dependency-handling
mathieujobin Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/paranoia/active_record_5_2.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module HandleParanoiaDestroyedInBelongsToAssociation
def handle_dependency
return unless load_target
return unless options[:dependent]

case options[:dependent]
when :destroy
Expand All @@ -18,6 +19,8 @@ def handle_dependency

module HandleParanoiaDestroyedInHasOneAssociation
def delete(method = options[:dependent])
return unless options[:dependent]

if load_target
case method
when :delete
Expand Down