x509cert: check for error of X509_set_serialNumber()#1031
Merged
Conversation
This function may return 0 on error [1]. [1] https://manpages.debian.org/stretch/libssl-doc/X509_set_serialNumber.3ssl.en.html
rhenium
approved these changes
Apr 20, 2026
Member
rhenium
left a comment
rhenium
left a comment
There was a problem hiding this comment.
This call seems to always succeed in the current implementation, but we should still check it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function may return 0 on error [1].
[1] https://manpages.debian.org/stretch/libssl-doc/X509_set_serialNumber.3ssl.en.html
This was found by a hybrid static-dynamic analyser that looks for inconsistent handling of error checks in bindings.