Fix bitrot#15
Open
VorpalBlade wants to merge 3 commits into
Open
Conversation
-d means something different nowdays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14 plus some other issues (such as not working with modern bpftrace).
This is only lightly tested (using Arch Linux), but recreating the demo from the video works. But I also managed to get it to error out with an invalid bpftrace program at one point (not sure what I did). However, this PR takes it from not working at all, to working a bit.
cc @NHOrus as you opened a bug about failing to build with cmake 4. Maybe you are interested in this? I suspect upstream is actually entirely dead. (But this is quite a neat tool, if someone wants to build on this, which I don't think will be me, I just wanted to experiment with it.)