Skip to content

rosserial_server: Fix access to uninitialized memory in handling service calls #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peci1 wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from
+2 −3
Open

rosserial_server: Fix access to uninitialized memory in handling service calls #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions rosserial_server/include/rosserial_server/topic_handlers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,8 @@ class ServiceClient {
ros::serialization::Serializer<topic_tools::ShapeShifter>::read(stream, request_message_);

// perform service call
// note that at present, at least for rosserial-windows a service call returns nothing,
// so we discard the return value of this call() invocation.
service_client_.call(request_message_, response_message_, service_md5_);
if (!service_client_.call(request_message_, response_message_, service_md5_))
return;

// write service response over the wire
size_t length = ros::serialization::serializationLength(response_message_);
Expand Down