Fix stressGUI#22193
Open
bellenot wants to merge 4 commits into
Open
Conversation
Test Results 22 files 22 suites 3d 11h 7m 54s ⏱️ Results for commit bdbbfe7. ♻️ This comment has been updated with latest results. |
linev
approved these changes
May 20, 2026
| bexec(dir, "tree500_cernbuild.C"); | ||
| } | ||
| dir = gRootSys + "/tutorials/gui"; | ||
| dir = gRootSys + "/tutorials/visualisation/gui"; |
Member
There was a problem hiding this comment.
Maybe here and in other places use TROOT::GetTutorialDir(). Like:
Suggested change
| dir = gRootSys + "/tutorials/visualisation/gui"; | |
| dir = TROOT::GetTutorialDir() + "/visualisation/gui"; |
Member
Author
There was a problem hiding this comment.
Good point! Let me change that...
Member
Author
There was a problem hiding this comment.
@linev It would require gSystem->UnixPathName(TROOT::GetTutorialDir()) and then I got error C2110: '+': cannot add two pointers. SO I'll keep it the way it is now and I'll change this later
Member
There was a problem hiding this comment.
Up to you.
I will try to enable stressGUI for CI - using xvfb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.