Skip to content

[RF] fix memleak in rooabscollection::find #18327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 3 commits into from
Apr 10, 2025
Merged

[RF] fix memleak in rooabscollection::find #18327

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4cace9
[RF] fix memleak in rooabscollection::find
ferdymercury Apr 9, 2025
8279043
[RF] microoptimize, no delete on nullptr
ferdymercury Apr 10, 2025
6696ce9
Clangformat
ferdymercury Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions roofit/roofitcore/src/RooAbsCollection.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,8 @@ RooAbsArg * RooAbsCollection::find(const char *name) const

if (_hashAssistedFind || _list.size() >= _sizeThresholdForMapSearch) {
if (!_hashAssistedFind || !_hashAssistedFind->isValid()) {
if (_hashAssistedFind)
delete _hashAssistedFind;
Comment thread
ferdymercury marked this conversation as resolved.
Outdated
_hashAssistedFind = new HashAssistedFind{_list.begin(), _list.end()};
}

Expand Down