Skip to content

Fix link formatting in README.md#1929

Open
ales1sobol wants to merge 1 commit into
rolling-scopes-school:masterfrom
ales1sobol:patch-1
Open

Fix link formatting in README.md#1929
ales1sobol wants to merge 1 commit into
rolling-scopes-school:masterfrom
ales1sobol:patch-1

Conversation

@ales1sobol
Copy link
Copy Markdown
Contributor

https://rs.school/docs/en/git-convention was not working

Title of Pull Request

🤔 This is a

  • 🌟 New task
  • 🌐 New module
  • ⚙️ Update to an existing task
  • 🔧 Update to an existing module
  • 🔗 Update or addition of external resources or links
  • 🐛 Fix in a task or related content
  • 🛠 Fix in a module or related content
  • ✏️ Fixed a typo or grammatical error
  • [1] 🔗 Fixed a broken link
  • ❓ Other (specify: ****____****)

Description

  • Brief Overview:
    Need to delete /en/ in link
  • Implementation Approach:

Additional Information

  • Screenshots/Links:
  • Related Issues:

Checklist

  • [1] ✅ I have performed a self-review of my own code.
  • 📝 I have commented my code, particularly in hard-to-understand areas.
  • 🔧 I have made corresponding changes to the documentation (if applicable).
  • 🚫 My changes generate no new warnings or errors.

@pavelhalanin
Copy link
Copy Markdown
Contributor

This URL returns HTTP status 404:
https://rs.school/docs/en/git-convention

I found pages that return HTTP status 200:

git commit -m "docs: fixed the broken link" (PR #1931)

- [Use commit names according to the guideline [EN]](https://rs.school/docs/git-convention) / [RU](https://rs.school/ru/docs/git-convention)

@ales1sobol
Copy link
Copy Markdown
Contributor Author

ales1sobol commented Mar 21, 2026

git commit -m "docs: fixed the broken link" (PR #1931)
@pavelhalanin - Present tense ("add feature" not "added feature") should be used.

## Theory

1. You should read and remember [commits requirements](https://rs.school/docs/en/git-convention) in RS School
1. You should read and remember [commits requirements]([https://rs.school/docs/git-convention]) in RS School
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the markdown link format (extra brackets in URL)
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants