Add file icons for bsconfig.json and brsconfig.json#801
Open
TwitchBronBron wants to merge 2 commits into
Open
Conversation
Defines `bsconfig` and `brsconfig` as languages so VSCode can attach custom file icons. Both languages reuse the built-in JSON-with-comments grammar via a stub `.tmLanguage.json`, which restores syntax highlighting and lets `jsonValidation` apply `bsconfig.schema.json`.
chrisdp
previously approved these changes
May 20, 2026
chrisdp
dismissed
their stale review
Found issues like editor.bracketPairColorization.enabled native settings stop working, json schema editor feedback no longer applying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bsconfig.json(BrighterScript) andbrsconfig.json(BrightScript), styled to match the built-intsconfig.jsoniconbsconfig/brsconfigas languages so VSCode can attach the icons via filename patternssyntaxes/jsonc.tmLanguage.jsonthat re-uses VSCode's built-insource.json.commentsscope — without this, the new languages would render as plain text andjsonValidationwould never apply the schemaHere's how they look, in practice (and the tsconfig.json and jsconfig.json for reference)
Test plan
bsconfig.jsonandbrsconfig.jsonshow the new colored "BS"/"BRS" icons in the file explorerbsconfig.schema.jsonvalidation kicks in (hover, completions, error squigglies on bad values)🤖 Generated with Claude Code