Skip to content

Fix while with parentheses colorization #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philanderson888 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix while with parentheses colorization #611

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3829cf9
Initial fix of issue 197 - visual confirmation only - no tests run
philanderson888 Jan 30, 2025
15170b9
put back if_wth_paren and function_call
philanderson888 Jan 31, 2025
7286d81
add include for while statement
philanderson888 Jan 31, 2025
4bf902d
Merge branch 'master' into issue-197-incorrect-coloring-of-key-words
TwitchBronBron Jun 5, 2025
2481797
Merge branch 'master' into issue-197-incorrect-coloring-of-key-words
chrisdp Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions syntaxes/brightscript.tmLanguage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,33 +689,6 @@
}
}
},
"if_with_paren": {

@TwitchBronBron TwitchBronBron Jan 30, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. At first glance, I think this is not the correct approach.

We don't have a lot of unit tests around the syntaxes, so I don't have full confidence as to why these deleted items are still needed, but I'm thinking a better approach would be to add the correct colorizing for those keywords rather than delete whatever else is colliding with them.

Also, if you do end up deleting these, you'll need to remove their references from the list above too, (look for #if_with_paren and #function_call

"begin": "(?i:(?<!\\.)(if)\\s*\\()",
"beginCaptures": {
"1": {
"name": "keyword.control.brs"
}
},
"patterns": [
{
"include": "#entire_language"
}
],
"end": "\b(then)|\n",
"endCaptures": {
"1": {
"name": "keyword.control.brs"
}
}
},
"function_call": {
"captures": {
"1": {
"name": "entity.name.function.brs"
}
},
"match": "(?i:\\b([a-z_][a-z0-9_]*)[ \\t]*(?=\\())"
},
"function_declaration": {
"captures": {
"1": {
Expand Down