Skip to content

[parsing] Warn about another recovery mechanism #20870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coqbot-app merged 1 commit into from
Jul 14, 2025
Merged

[parsing] Warn about another recovery mechanism #20870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion gramlib/grammar.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,11 +1320,15 @@ and parser_of_symbol : type s tr a.
let al =
try ps gstate strm__ :: al with
Stream.Failure ->
if not gstate.recover then raise Stream.Failure else
let bp = LStream.count strm__ in
let a =
try parse_top_symb entry symb gstate strm__ with
Stream.Failure ->
raise (Error (symb_failed entry v sep symb))
in
let ep = LStream.count strm__ in
let () = warn_recover_continuation bp ep strm__ in
a :: al
in
kont gstate al strm__
Expand All @@ -1344,11 +1348,16 @@ and parser_of_symbol : type s tr a.
with
Some al -> kont gstate al strm__
| _ ->
if not gstate.recover then al else
let bp = LStream.count strm__ in
match
try Some (parse_top_symb entry symb gstate strm__) with
Stream.Failure -> None
with
Some a -> kont gstate (a :: al) strm__
Some a ->
let ep = LStream.count strm__ in
let () = warn_recover_continuation bp ep strm__ in
kont gstate (a :: al) strm__
| _ -> al
end
| _ -> al
Expand Down