Sensitivity#63
Draft
jnnr wants to merge 45 commits into
Draft
Conversation
Sensitivity salib
jnnr
commented
Oct 13, 2022
| self.eps, | ||
| ).all(), f"The difference between lb and ub is lower than the defined minimum of {self.eps}" | ||
|
|
||
| def get_diff(self): |
| def get_diff(self): | ||
| return get_diff(self.lb.loc[:, self.VAR_VALUE], self.ub.loc[:, self.VAR_VALUE]) | ||
|
|
||
| def get_param(self): |
| self.sanity_check() | ||
|
|
||
| return _dp | ||
| def sanity_check(self): |
Collaborator
Author
There was a problem hiding this comment.
Decouple sample method and sanity check.
| return full_samples | ||
|
|
||
|
|
||
| class EDPSensitivity(Sensitivity): |
Collaborator
Author
There was a problem hiding this comment.
This could be done more general. The above Sensitivity class does checking and sampling for a single dataframe. This class is supposed to do the same for DataFramePackages.
The implementation takes some time to grasp - could be more transparent?
| # assert that the last sample equals the upper-bound datapackage | ||
| assert frame_containing_nan_equal( | ||
| samples["sample_" + str(n - 1)], edp_ub_stacked.data["component"] | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Add a check that actually compares results files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to create new EnergyDatapackages from two existing EnergyDatapackages and a sampling function. First implemented sampling functions