feat(sink): cherry-pick limit StarRocks stream load batch size (#25750)#26307
Queued
risingwave-ci with Copilot wants to merge 2 commits into
Queued
feat(sink): cherry-pick limit StarRocks stream load batch size (#25750)#26307risingwave-ci with Copilot wants to merge 2 commits into
risingwave-ci with Copilot wants to merge 2 commits into
Conversation
Collaborator
|
@copilot Would you please finish this work? |
Co-authored-by: cyliu0 <35356271+cyliu0@users.noreply.github.com>
Contributor
Author
Done. Applied the cherry-pick of PR #25750 onto release-3.0. Changes committed in
|
Collaborator
|
@copilot fix the PR title |
Contributor
Author
I don't have direct access to update the PR title. The recommended title is:
Could you please update it manually? |
zwang28
marked this pull request as ready for review
July 17, 2026 02:17
zwang28
approved these changes
Jul 17, 2026
zwang28
enabled auto-merge
July 17, 2026 02:18
cyliu0
approved these changes
Jul 17, 2026
zwang28
added this pull request to the merge queue
Jul 17, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Backport #25750 to
release-3.0by cherry-picking commite29a68a17bebaffa0ee60ccea9159acdeb03c7a0.This change adds the optional
starrocks.max_batch_size_bytessetting for StarRocks sinks. The setting:The sink writer tracks the current request size and finishes the current load request before adding a row that would exceed the configured limit. It then opens another load request within the same StarRocks transaction. A single row whose encoded payload exceeds the limit fails with a clear error instead of sending an oversized request.
The shared write path applies the limit to append-only and upsert sinks. This backport also exposes the option in generated sink metadata and corrects the StarRocks JSON error wording from “derialize” to “serialize”.
Testing
Added seven unit tests covering:
The cherry-pick agent reports all seven tests passing.
Checklist
Documentation
Release note
StarRocks sinks in release 3.0 support the optional
starrocks.max_batch_size_bytessetting. When configured, RisingWave splits stream load requests before their encoded JSON payload exceeds the specified positive byte limit. The setting defaults to unlimited when omitted and can be altered on the fly.